Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect user-provided authority queries and add to options.ExtraQueryParams #2848

Merged
merged 8 commits into from
May 28, 2024
Merged

Respect user-provided authority queries and add to options.ExtraQueryParams #2848

merged 8 commits into from
May 28, 2024

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented May 17, 2024

Fixes #2697

@kllysng kllysng requested a review from a team as a code owner May 17, 2024 18:40
@keegan-caruso
Copy link
Contributor

Please address the GH warnings

@jennyf19
Copy link
Collaborator

Is the commit history right? If not, might want to clean it up.

@kllysng
Copy link
Contributor Author

kllysng commented May 17, 2024

Please address the GH warnings

Done!

Is the commit history right? If not, might want to clean it up.

I actually had been attempting to squash the history but it added two more commits. Will try again.

@kllysng kllysng force-pushed the kellysong/user-provided-query branch from db2d54a to f5c1335 Compare May 17, 2024 23:26
pmaytak
pmaytak reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please test E2E with a web app / API, if you haven't done so.
  • Create a bug - currently web app don't work if authority has query params. (the details in chat).

@kllysng
Copy link
Contributor Author

kllysng commented May 22, 2024 •
edited
Loading

  • Please test E2E with a web app / API, if you haven't done so.

image

  • Create a bug - currently web app don't work if authority has query params. (the details in chat).

It works now 😄

jennyf19
jennyf19 approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Will this go in rel/v2 as well?

@jennyf19 jennyf19 merged commit dcc72c8 into master May 28, 2024
5 checks passed
@jennyf19 jennyf19 deleted the kellysong/user-provided-query branch May 28, 2024 01:01
jennyf19 added a commit that referenced this pull request May 28, 2024
@kllysng @jennyf19
Respect user-provided authority queries and add to options.ExtraQuery…
bdeba7e 
…Params (#2848)

* parse user provided authority queries into options.ExtraqueryParameters + tests

* change requests

* change requests

* update authority to remove qp's and only add to EQP dictionary + tests

---------

Co-authored-by: jennyf19 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso left review comments

@jennyf19 jennyf19 jennyf19 approved these changes

@pmaytak pmaytak pmaytak approved these changes

@westin-m westin-m westin-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process the query part of the authority when present
5 participants
@kllysng @keegan-caruso @jennyf19 @pmaytak @westin-m